refactor: defer deposit/borrow limit checks to the end_flashloan ix #251
+133
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #196. The second point is already implemented because in the flashloan_success_1op test in programmes/marginfi/tests/user_actions/flash_loan.rs, the user borrows money and pays it back, which is the process of going from poor health to normal.
The unfulfilled understanding of the first point (Defer deposit/borrow limit checks to the end_flashloan ix) is as follows:
lending_account_borrow
function,BalanceDecreaseType::Any
is passed in whenbank_account.borrow
, which is the borrow function ofBankAccountWrapper
.BalanceDecreaseType::Any
was passed in, performs Bank's deposit and debit checks.